lite-xl / lite-xl-ide

A set of plugins to convert lite-xl into a proper IDE.
22 stars 5 forks source link

"press any key" prompt doesn't close terminal when any key is pressed #14

Open thacuber2a03 opened 2 months ago

thacuber2a03 commented 2 months ago

(at least in gnome-terminal) I'm unable to "press any key" to exit as it just adds it as input, I need to press enter for it to actually exit image

thacuber2a03 commented 2 months ago

~~in the case of a raylib program, it just doesn't exit, not even through the close button I have to close the terminal itself for it to close since raylib is just OpenGL, I wonder if this applies to OpenGL programs too~~

nevermind this, I forgot to loop while !WindowShouldClose()

adamharrison commented 3 weeks ago

That's really werid. Let me test.

adamharrison commented 3 weeks ago

This works for me with the new changes in ee55f7, and

config.plugins.build.terminal = { "gnome-terminal", "-e" }

Can you try with those new changes and that configuration, and let me know if you're still hitting that error?

thacuber2a03 commented 3 weeks ago

I don't use Lite XL master :/

thacuber2a03 commented 3 weeks ago

jeez, not even master, the changes have mod-version 4.0

adamharrison commented 3 weeks ago

Yeah, it's 3.0. you can probably cherry pick the commit into master ide

adamharrison commented 3 weeks ago

I will look at rebasing master potentially. We'll see.

adamharrison commented 3 weeks ago

Hrm. There are a number of changes specific to the thing for mod-version 4. How opposed are you to changing over?

thacuber2a03 commented 3 weeks ago

it's not that I'm opposed, I'm not even sure how to change over

adamharrison commented 3 weeks ago

You have lpm right? Can you give me the output of lpm describe?

thacuber2a03 commented 3 weeks ago
lpm run system https://github.com/lite-xl/lite-xl-plugins.git:master https://github.com/lite-xl/lite-xl-colors.git:master meta_addons:0.1 meta_colors:0.1 meta_languages:0.1.18 align_carets:0.1 autoinsert:0.2 autosaveonfocuslost:0.2 bracketmatch:0.2 cleanstart:0.1 colorpicker:0.1 colorpreview:0.2 console:0.1 copyfilelocation:0.1 fontpreview:0.1 ephemeral_tabs:0.1 eval:0.1 evergreen:0.1 exec:0.1 extend_selection_line:0.1 font_symbols_nerdfont_mono_regular:3.1.1 ghmarkdown:0.2 gitblame:0.2.1 gitdiff_highlight:0.1 gitopen:0.1 gitstatus:0.2 indent_convert:0.1 language_containerfile:0.1 language_crystal:0.1 language_djot:0.1 language_env:0.1 language_ignore:0.1 language_vale:0.1 lfautoinsert:0.3 lintplus:0.2 lsp:0.8 lsp_snippets:1.1 minimap:0.2 motiontrail:0.2.1 plugin_manager:0.1 primary_selection:0.2 rainbowparen:0.1.1 restoretabs:0.1 scalestatus:0.1 selectionhighlight:0.2 smallclock:0.1 smoothcaret:0.2 snippets:1.1 sticky_scroll:1.0 su_save:1.0 svg_screenshot:0.1 thread:1.3 treeview-extender:1.0.0 ayu-dark:0.1 ayu-mirage:0.1 justperfect:0.1 welcome:0.1 json:1.0 language_toml:1.0 language_gluon:1.0 terminal:1.0 indentguide:1.0 language_nim:1.0 equationgrapher:1.0 language_java:1.0 nerdicons:1.0 language_kotlin:1.0 language_json:1.0 language_csharp:1.0 settings:1.0 language_r:1.0 language_jsx:1.0 language_go:1.0 language_angelscript:1.0 language_nix:1.0 language_fortran:1.0 language_batch:1.0 language_c:1.0 language_marte:1.0 language_graphql:1.0 scale:1.0 language_pkgbuild:1.0 language_md:1.0 language_toml:1.0 language_python:1.0 language_clojure:1.0 language_tsx:1.0 language_assembly_riscv:1.0 language_ini:1.0 language_blade:1.0 language_carbon:1.0 language_miniscript:1.0 language_tcl:1.0 open_ext:1.0 language_zig:1.0 language_scala:1.0 trimwhitespace:1.0 toolbarview:1.0 language_hare:1.0 language_dart:1.0 language_make:1.0 language_bend:1.0 language_assembly_x86:1.0 language_css:1.0 language_pico8:1.0 language_lilypond:1.0 contextmenu:1.0 language_tal:1.0 language_xml:1.0 language_julia:1.0 language_lua:1.0 language_ejs:1.0 language_fe:1.0 language_edp:1.0 autocomplete:1.0 language_fstab:1.0 language_meson:1.0 language_haxe:1.0 language_c7:1.0 language_ruby:1.0 language_htaccess:1.0 language_bazel:1.0 language_liquid:1.0 language_hlsl:1.0 language_groovy:1.0 language_openscad:1.0 language_html:1.0 language_autohotkey_v1:1.0 language_nim:1.0 language_erb:1.0 language_umka:1.0 language_d:1.0 language_po:1.0 language_java:1.0 language_jiyu:1.0 detectindent:1.0 language_hs:1.0 language_glsl:1.0 language_cue:1.0 language_swift:1.0 language_rust:1.0 treeview:1.0 language_cmake:1.0 language_moon:1.0 language_rivet:1.0 language_nginx:1.0 language_brainfuck:1.0 language_ts:1.0 linewrapping:1.0 language_objc:1.0 language_gabc:1.0 language_powershell:1.0 language_cpp:1.0 reflow:1.0 language_elixir:1.0 language_sass:1.0 language_yaml:1.0 language_tex:1.0 language_teal:1.0 language_lox:1.0 language_nelua:1.0 macro:1.0 language_typst:1.0 language_diff:1.0 language_gravity:1.0 tabularize:1.0 language_v:1.0 projectsearch:1.0 language_js:1.0 lineguide:1.0 language_lobster:1.0 language_fennel:1.0 language_blueprint:1.0 language_ssh_config:1.0 drawwhitespace:1.0 autoreload:1.0 language_php:1.0 language_kotlin:1.0 quote:1.0 language_elm:1.0 language_sh:1.0 language_perl:1.0 workspace:1.0 language_wren:1.0 language_gmi:1.0 language_psql:1.0 language_rescript:1.0 language_gdscript:1.0 language_bib:1.0 language_json:1.0 language_odin:1.0 language_caddyfile:1.0 language_buzz:1.0 widget:1.0 icons-ttf:1.0 firasans-regular-ttf:1.0 jetbrainsmono-regular-ttf:1.0 synthwave:1.0 default:1.0 plasma:1.0 monokai-sublime:1.0 vscode-dark:1.0 abyss:1.0 gruvbox_dark:1.0 cold_lime:1.0 tokyo-night:1.0 gruvbox_light:1.0 liqube:1.0 jellybeans:1.0 textadept:1.0 betelgeuse:1.0 solarobj:1.0 mariana:1.0 github_dark:1.0 catppuccin-macchiato:1.0 monodark:1.0 rose-pine-dawn:1.0 moe:1.0 rose-pine:1.0 jb-fleet:1.0 nord:1.0 everforest_light:1.0 monokai-pro-classic:1.0 predawn:1.0 catppuccin-frappe:1.0 synthwave:1.0 onedark:1.0 focus:1.0 dracula:1.0 only_dark:1.0 fall:1.0 winter:1.0 flexoki_dark:1.0 hackersden:1.0 duorand:1.0 bearded-theme-vivid-black:1.0 mobilephone:1.0 catppuccin-mocha:1.0 duotone:1.0 github:1.0 solarized_dark:1.0 github-dark-dimmed:1.0 rose-pine-moon:1.0 summer:1.0 solarized_light:1.0 zenburn:1.0 monokai:1.0 catppuccin-latte:1.0 everforest:1.0 flexoki_light:1.0 c0mfy:1.0

how does this help though

adamharrison commented 3 weeks ago

I'm trying to see if I can give you a command that'll run your plugin setup on 3.0.

Will look at this this week