Rendering issues for inline diagnostics

lite-xl / lite-xl-lsp

LSP Plugin for Lite XL editor

MIT License

160 stars 21 forks source link

Rendering issues for inline diagnostics #114

Closed aCursedComrade closed 7 months ago

aCursedComrade commented 7 months ago

New user here trying out lite-xl and the plugins it has. I ran into this issue that is very much similar to what #48 describes. I have tried rust-analyzer and pyright setups on my end, diagnostics do get reported correctly and viewable from status bar. Running Lsp: Toggle Diagnostics twice (first it disables and then enables again) renders them in the document but continues to either stay statically or disappears until I run the command twice again. I'm not seeing any errors in the logs as well.

lite-xl-lsp_missing_inline_diagnostics

lite-xl-lsp_diagnostics_arent_updated

All plugins were installed through lpm.

OS: Windows 10 Lite-xl version: 2.1.3 user init.lua and plugin hierarchy:

lite-xl_config

Guldoman commented 7 months ago

Seems to work here with pyright installed via the plugin lsp_python:

Video del 2024-03-27 16-37-33.webm

Am I missing something about this issue?

Could you test with lsp_python too? Maybe even in an lpm bottle (lpm run --ephemeral lsp_python).

aCursedComrade commented 7 months ago

I tried lsp_rust and lsp_python in the system install before reporting here too, but it turned out be same case.

Bottles are affected as well on my end apparently: lpm run --ephemeral lsp_python

https://github.com/lite-xl/lite-xl-lsp/assets/71869007/47ab71ae-b34e-475f-a3ea-bf9470979bf1

PS: dont worry about the unresolved dependencies in the video, it supposed to be in a poetry managed env but it is not setup on this box.

aCursedComrade commented 7 months ago

Apologies for not giving any updates but I'm gonna close this issue here as I was simply trying out lite-xl out of curiosity. Could've helped more if I was more comfortable with Lua :(

Guldoman commented 7 months ago

No worries. Sadly I still wasn't able to reproduce it, and neither could another contributor, but I'll keep this in mind if I manage to by chance.

Guldoman commented 5 months ago

Hey @aCursedComrade, could you check if this got fixed with 21faf00bdcb59e5b81ae8b1018d262cbf84efc81? See https://github.com/lite-xl/lite-xl-lsp/issues/129#issuecomment-2143535168.

aCursedComrade commented 5 months ago

Thank you for reaching out back to me again! I can confirm it does work flawlessly now on Windows. I'll re-close this issue as completed then. Thanks again for your time.

Guldoman commented 5 months ago

Thank @Callmore for finding the root cause!