support additionalTextEdits for autocomplete results

lite-xl / lite-xl-lsp

LSP Plugin for Lite XL editor

MIT License

160 stars 21 forks source link

Closed pfgithub closed 5 months ago

pfgithub commented 1 year ago

In typescript, autocompleting something will create additionalTextEdits if it needs to do something like add an import

Issues:

This likely won't work if there are two additional edits because one will be inserted and then the next one will try to insert in the wrong place
If you accept the autocomplete too fast, it won't work because the completionItem/resolve response hasn't come in yet

PerilousBooklet commented 5 months ago

Should we close this, since #128 was merged?

Guldoman commented 5 months ago

Yep. @pfgithub thank you for the contribution, it inspired #128.