search

lite-xl / lite-xl-plugin-manager

A lite-xl plugin manager.
Other
102 stars 14 forks source link

Lpm flags issue for core libs as dependencies if lite-xl is not installed #112

Closed RohanVashisht1234 closed 3 months ago

RohanVashisht1234 commented 4 months ago

image

Guldoman commented 4 months ago

There seems to be a difference between run and install:

$ lpm --userdir . install lsp_typescript
can't find dependency language_js
$ lpm --userdir . run lsp_typescript
$
adamharrison commented 4 months ago 
adam@adam-ThinkPad-T15p-Gen-1:/tmp$ lpm --userdir . install lsp_typescript
   2.3 MB [   3.0 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-plugin-manager.git:latest...
 336.2 kB [   3.1 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-plugins.git:master...
  44.3 kB [   1.0 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-colors.git:master...
  24.9 kB [   1.9 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-lsp-servers:89efc5642cb9abcd9023c8e5ef3dba85b399884e...
Installing singleton plugin language_ts.
 981.0 kB [   3.9 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-lsp:b1b77d143b2c6e3cd953b3573ea1a96dd61ff3bb...
lintplus is an optional dependency of lsp. Should we install it? [Y/n]: 
  63.0 kB [ 977.4 kB/s][100%]: Fetching https://github.com/liquid600pgm/lintplus:771b1fe6cddb7897cd034ed5ee96201d6a2831c2...
Installing complex plugin lintplus.
lsp_snippets is an optional dependency of lsp. Should we install it? [Y/n]: 
  26.4 kB [ 726.6 kB/s][100%]: Fetching https://github.com/vqns/lite-xl-snippets:1f0bba02bb3af6df9cb2ce72526851b427caf143...
json is an optional dependency of lsp_snippets. Should we install it? [Y/n]: 
Installing singleton library json.
Installing singleton plugin snippets.
Installing singleton plugin lsp_snippets.
  62.8 kB [ 946.9 kB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-widgets:61789bdc87d52ba7838927af9aa2671efdcea185...
Installing complex library widget.
Installing complex plugin lsp.
  25.4 kB [ 817.1 kB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-lsp-servers:1df8be64ad87efa45341d8c3953df60d90f9539b...
Installing complex library nodejs.
  44.5 MB [  11.0 MB/s][100%]: Downloading https://nodejs.org/dist/v20.12.0/node-v20.12.0-linux-x64.tar.gz...
Installing complex plugin lsp_typescript.
   5.7 MB [  10.2 MB/s][100%]: Downloading https://github.com/adamharrison/lite-xl-lsp-servers/releases/download/typescript-language-server-4.3...
adamharrison commented 4 months ago

Seems to work fine on my end, weirdly enough.

adamharrison commented 4 months ago

Seems like it's to do with auto-detecting your lxl install. If you don't have one, this fails.

I'll have flagged core plugins as still core, even if they're not part of your non-existent install.

adamharrison commented 4 months ago

Should be fixed by 0d153a3148382242ae2a71511664bb1a106b6fc5.

Guldoman commented 3 months ago

Doesn't seem to be fixed sadly:

$ cd `mktemp -d`
$ mkdir data
$ lpm --cachedir ./cache --datadir ./data install '*' --verbose
   2.3 MB [   9.5 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-plugin-manager.git:latest...
 337.0 kB [   3.4 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-plugins.git:master...
  45.0 kB [   1.5 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-colors.git:master...
  63.0 kB [ 984.4 kB/s][100%]: Fetching https://github.com/liquid600pgm/lintplus:771b1fe6cddb7897cd034ed5ee96201d6a2831c2...
  26.4 kB [ 830.6 kB/s][100%]: Fetching https://github.com/vqns/lite-xl-snippets:1f0bba02bb3af6df9cb2ce72526851b427caf143...
 983.1 kB [   3.8 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-lsp.git:ed8345488ee97d3ee99605025303a40ec301a513...
  32.2 kB [   4.0 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-lsp-servers.git:b4e1929f6fea6a21e2706ebfb6cb28c48453357d...
  62.8 kB [ 979.7 kB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-widgets:61789bdc87d52ba7838927af9aa2671efdcea185...
  30.4 kB [  12.1 MB/s][100%]: Fetching https://github.com/lite-xl/lite-xl-lsp-servers:89efc5642cb9abcd9023c8e5ef3dba85b399884e...
lpm.lua:866: can't find dependency language_js
stack traceback:
    [C]: in function 'error'
    lpm.lua:976: in method 'install'
    lpm.lua:1990: in local 'p'
    lpm.lua:385: in field 'each'
    lpm.lua:1988: in field 'install'
    lpm.lua:2269: in function <lpm.lua:2253>
    (...tail calls...)
    lpm.lua:2292: in field 'run'
    lpm.lua:2807: in function <lpm.lua:2806>
    [C]: in field 'flock'
    lpm.lua:555: in upvalue 'engage_locks'
    lpm.lua:2806: in function <lpm.lua:2326>
    [C]: in function 'xpcall'
    lpm.lua:2326: in main chunk
$ lpm --version
v1.2.9-17-g22152f1
adamharrison commented 3 months ago

Should be fixed by https://github.com/lite-xl/lite-xl-plugin-manager/commit/259331a015432cfd47eb5c6161c6ddf05288a01c.