search

lite-xl / lite-xl-plugin-manager

A lite-xl plugin manager.
Other
102 stars 14 forks source link

Meson doesn't use specified submodule for libgit2. #81

Open adamharrison opened 6 months ago

adamharrison commented 6 months ago

When I compile with meson, I get:

../src/lpm.c:318:16: error: ‘GIT_OID_SHA1_SIZE’ undeclared (first use in this function); did you mean ‘GIT_OID_RAWSZ’?
  318 |   if (length < GIT_OID_SHA1_SIZE*2) {
      |                ^~~~~~~~~~~~~~~~~

Presumably because it's using the system version. Can we default this to the submodule version, @Guldoman, @Jan200101 ?

Guldoman commented 6 months ago

Sure, I can make it use the submodules by default and add an option to force using the system versions.

adamharrison commented 6 months ago

:+1:

Jan200101 commented 6 months ago

this commit changed GIT_OID_RAWSZ to GIT_OID_SHA1_SIZE https://github.com/libgit2/libgit2/commit/dbc4ac1c76827e954e0aa27afe8bb7e0b8993a93 the earliest tag with it included is v1.6.1

According to the debian tracker it only has 1.5.1 in stable, ouch.