search

litebird / litebird_sim

Simulation tools for LiteBIRD
GNU General Public License v3.0
18 stars 13 forks source link

Bandpass information not passed to mbs #269

Closed sgiardie closed 9 months ago

sgiardie commented 11 months ago

In mbs there should the possibility to pass a bandpass to use in band integration. The instrument information are passed through the _InstrumentFreq class. Though, in the methods below, like the one to pass a dictionary, the band attribute is automatically set to None. If we set it to dictionary["band"] instead it works. Should that line and the ones below (47 and 58) be fixed?

ziotom78 commented 11 months ago

Absolutely! I missed that, please update .from_dict as you said. Thanks!

ziotom78 commented 9 months ago

I believe that PR #271 fixed this issue. @sgiardie I'm closing it, if you think it's wrong feel free to reopen it!