litecoin-foundation / litewallet-android

Litewallet Android
MIT License
34 stars 12 forks source link

🐜[Bugfix] Fragment fingerprint crash 125 #131

Closed kcw-grunt closed 1 year ago

kcw-grunt commented 1 year ago

What was wrong?

When the user has a Fingerprint reader and has it enabled, the reader needs to dismiss the modal when the action has completed. The code had a smell in that it was removing an object that likely would still be alive. This is found in FingerprintFragment.java line (265) now 237

Firebase Crashlytics Link

What was done

Rather than remove the activity which was a top 2 Crash in the app, the animation call fingerPrintLayout.clearAnimation(). This is suggested as a solution here: https://stackoverflow.com/questions/4750939/android-animation-is-not-finished-in-onanimationend

Will monitor this over the next few days.

Closes #125

kcw-grunt commented 1 year ago
Update: This is looking good Current Suppression of the Crash
Screen Shot 2023-01-31 at 7 20 01 AM