litecoin-foundation / litewallet-android

Litewallet Android
MIT License
32 stars 12 forks source link

🥳[Feature] Add bech32 to enable ltc1 addresses #135

Closed kcw-grunt closed 1 year ago

kcw-grunt commented 1 year ago

We're back!

A few years ago, we tried to upgrade Litewallet for both platforms but the Bech32 upgrades were corrupting existing databases for Android users. We stopped the rollout .

This PR is re-adding the changes and the code compiles but now we have to strategize the way to help users migrate.

Here are the tests matrix that need to be tested:

Scenario Result Notes
New Install Can the user send L, M and 1ltc addresses?
Existing Install Can the user send L, M and 1ltc addresses?
Restore Can the user send L, M and 1ltc addresses?
New Install Can the user receive L, M and 1ltc addresses?
Existing Install Can the user receive L, M and 1ltc addresses?
Restore Can the user receive L, M and 1ltc addresses?
New Install Can the user sync and get all txs?
Existing Install Can the user sync and get all txs?
Restore Can the user sync and get all txs?

Closes #14

kcw-grunt commented 1 year ago

Update: New Install on Google Pixel 4a:

kcw-grunt commented 1 year ago

Testing: New Install Restored privkey on Google Pixel 4a:

kcw-grunt commented 1 year ago

@vsima . Hey Vic! I'm stuck here. Maybe you can see the obvious problem. What I'm trying to do is:

  1. Display a fragment that appears when the Wallet is inited (BRAnimator, line 78). This would ideally be right after the user unlocks.
  2. Fragment (FragmentBalanceSeedReminder.kt) has its layout (fragment_balance_seed_reminder.xml) and the user should be able to reveal the seed or dismiss.
  3. Currently, the fragment never shows. I'm really stuck here and frustrated 🤬. Any clues?

Do you see anything obviously missing?

vsima commented 1 year ago

@kcw-grunt I pushed a commit to fix the UI issue & added logic to retrieve and display the seed phrase.

kcw-grunt commented 1 year ago

@vsima the button and modal looks good but somehow the database pulls a new seed instead of showing the existing on. For instance the first word for this seed is extend but the new one is walnut

There is some trigger starting creating a new seed there and we don't want that. Can you look at it?

Recovery Seed Clip Wrong new seed
1ltc-error-short 1ltc-error-wrong
kcw-grunt commented 1 year ago

Ok we have a hybrid of @vsima work where I was able to not reset the seed call. This build .aab is in the closed track for testing

Tested v2.8.3 (727)
show-seed-phrase
kcw-grunt commented 1 year ago

its looking stable 🤞🏾

kcw-grunt commented 1 year ago

still looking stable! 1000+ devices running in Beta..no new bugs

@josikie @vsima can I get a look / review?

kcw-grunt commented 1 year ago
Added the FP option Changing the FP
sync-preferences-clip

The goal @vsima

kcw-grunt commented 1 year ago

Welcome @colin-yeoh this our latest 🔥!

Please clone and take a look at the submodules for the project