litecoin-foundation / litewallet-android

Litewallet Android
MIT License
34 stars 12 forks source link

🚀[ Release v.2.8.4] Merge into Main #138

Closed kcw-grunt closed 1 year ago

kcw-grunt commented 1 year ago

Overview

This is the last major release prior to work on Newborn, the refactored Litewallet Android. While there are many requests to improve the current codebase, it is actually 7 years of patching and rework and the cost / time of maintenance is no longer worth it.

We looked at the most important features needed and addressed them in this release.

They are:

Clips

Note some views

Show seed phrase
small-show-seed
Add user preference False Positives
sync-preferences-clip
kcw-grunt commented 1 year ago

Wow, looks nice! @kcw-grunt Why is inside onClick empty for below code?

if (BuildConfig.VERSION_NAME == "v2.8.4") {
            Snackbar.make(parentLayout,
                            R.string.release_notes,
                            Snackbar.LENGTH_INDEFINITE).setAction(R.string.Webview_dismiss, new View.OnClickListener() {
                        @Override
                        public void onClick(View view) {

                        }
                    })
                    .setActionTextColor(getResources().getColor(android.R.color.holo_red_light ))
                    .show();
 }

The comment said to show, what 'false' does on items.add on code line 130-134 file SettingsActivity.java?

Why do we need to clear DB table to enable Bech32 features?

Thanks @josikie ...you are too kind.

Why do we need to clear DB table to enable Bech32 features?:

The legacy db used a different schema for ltc addresses. So, adding new addresses (ltc1) would fail in that old db. One of the steps @vsima added was to have the device wipe the existing the db and add transactions to the new schema so now sending of L, M and ltc1 addresses is readable by the new schema.

The comment said to show, what 'false' does on items.add on code line 130-134 file SettingsActivity.java?

This is just a implementation detail in Android/Java Settings tables. So, it distinguishes a table item (section: false) to a table section (section: true). Truth is I just used the existing design and added the item for Show my seed

josikie commented 1 year ago

Thank you for the explanation! @kcw-grunt