Open kcw-grunt opened 1 year ago
Hello! @kcw-grunt From articles I read, this error will not affects the users experience because Android will avoids Activity state loss and simply thrown the IllegalStateException exception whenever the error occurs.
I can't reproduce the error, I already tried a few times. My guess this error might happened when user pressed back or home button which is triggered the onSaveInstanceState method while our App trying to commit transaction for upcoming fragment.
From the logs on Crashlytics dashboard, it seems the error frequently happened in BreadActivity, IntroActivity, and LoginActivity
Expected behavior
The exception for the error is Fatal Exception: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
, this error can be happened because we attempted to commit to FragmentTransaction after the Activity's state had been saved, which is results to Activity state loss. The transaction would not be remembered when we call commit() after onSaveInstanceState() is called, it was never recorded as part of the Activity's state in the first place.
Mobile device (please complete the following information): From the crashlytics informations, in 24 hours, the error affected two users. Their smartphone are Oppo and Oneplus with Android 13 as the OS, they got affected in background state. Litewallet Version: v2.9.0
@josikie Thanks for looking into this! What I'm thinking is instead of trying to fix the bug (as you said it effects few users) Will you open a PR to add a LWAnalytics test point? So, you can check out these files app/src/main/java/com/breadwallet/tools/manager/AnalyticsManager.java app/src/main/java/com/breadwallet/tools/util/BRConstants.java
Please add a test constant like:
public static final String _20230708_EKAF = "error_kill_all_fragments";