search

litecoin-foundation / litewallet-android

Litewallet Android
MIT License
32 stars 12 forks source link

TrustedNode.java accepts IPv6 IPs now #185

Closed Odontoceti closed 1 month ago

Odontoceti commented 1 month ago

Making use of java.net.InetAddress class TrustedNode.java can now tell if an IPv6 address is valid, and can tell if IPv4 are valid more easily. It also could resolve DNS names if so desired (or actually does?) but I haven't looked much into it. Anyway, "example.com" is rejected as invalid IPv4 even though it gets resolved in this commit.

Caveats: This is untested, I can't set up the Android development environment in the foreseeable future. This is neophyte level, I haven't developed software in Java for Android before, but I hope to at least give something to expand upon and get things started since IPv6 support is something I'd like to have on Litewallet.

I humbly submit this pull request.

kcw-grunt commented 1 month ago

Thanks for submitting this PR @Odontoceti

The reality it is simply a very low priority and it wont help a majority of users.

But I suggest you file this as a feature request issue here: https://github.com/litecoin-foundation/litewallet-android/issues/new/choose

We will look into it when it becomes relevant