search

litecore-archive / litecore-lib

A pure and powerful JavaScript Litecoin library
https://litecore.io/
Other
72 stars 85 forks source link

Fix implementation of hd derivation to be bip32 compliant #4

Closed braydonf closed 6 years ago

braydonf commented 7 years ago

See https://github.com/bitpay/bitcore-lib/pull/97 for more details.

braydonf commented 7 years ago

I think there is a non related test that needs updating at test/block/blockheader.js:236

losh11 commented 7 years ago

Haven't looked through this in depth, but are you using the BIP32 serialisation values defined in Bitcoin Core, or that defined in bip32.org?

Litecoin Core does not use the BIP32 serialisation value defined in bip32.org.

braydonf commented 7 years ago

Not related to the serialization values: https://github.com/litecoin-project/litecore-lib/blob/master/lib/networks.js#L135-L136