search

litecore-archive / litecore-litecoin

Fork of Litecoin core for use with Litecore
MIT License
146 stars 198 forks source link

Any suggestions about fixing tests from BitcoindComparisonTool? #1

Open ultragtx opened 7 years ago

ultragtx commented 7 years ago

Bitcoin uses BitcoindComparisonTool.jar to test bitcoind , the jar is downloaded from theuni/bitcoind-comparisontool (source code theuni/bitcoinj: A library for working with Bitcoin) which is a JAVA implementation of Bitcoin protocol (bitcoinj).

Obviously litecoin cannot pass the tests from BitcoindComparisonTool.jar because the whole library is written for bitcoin which has some different blockchain parameters and some different implementations.

So we have two options here

  1. Maintain a fork of bitcoinj, do all the necessary changes, make it litecoinj, it's not worth to maintain a whole library just for a unit test.
  2. Disable this test, which zcash choose, Disable comparison utility by str4d · Pull Request #800 · zcash/zcash
ultragtx commented 7 years ago

related commits: https://github.com/bitcoin/bitcoin/commit/dd9bcad

thrasher- commented 7 years ago

For 0.13.1 I think its safe to disable the test. Long term, we will need to maintain a port of bitcoinj as its used for the Litecoin Android wallet.