search

litecore-archive / litecore-litecoin

Fork of Litecoin core for use with Litecore
MIT License
146 stars 198 forks source link

Is this project dead? #6

Open APshenkin opened 6 years ago

APshenkin commented 6 years ago

Hi!

Found this project from https://insight.litecore.io/.

I see, that you still use litecoin-0.13.2. Do you plan to update to 0.16 ?

LitecoinTim commented 6 years ago

Good you found the project - it certainly isn't dead! We'll be working on updating the public nodes - can't give you an ETA yet though.

APshenkin commented 6 years ago

@LitecoinTim Thank you for response!

Maybe I can help you with node patching. I've already applyed patches for 0.15.1 and 0.16.0 version. You can check the code here: https://github.com/APshenkin/litecoin/tree/0.15.1-litecore https://github.com/APshenkin/litecoin/tree/0.16.0-litecore

Here is comparation for 0.15.1 version (usual node and litecore node) https://github.com/litecoin-project/litecoin/compare/v0.15.1...APshenkin:0.15.1-litecore

and for 0.16.0 version https://github.com/litecoin-project/litecoin/compare/v0.16.0...APshenkin:0.16.0-litecore

Patches was dumped from satoshilabs (because only them applyed patches to 0.15.1 version for bitcoin https://github.com/satoshilabs/bitcoin/tree/0.15.0)

There are two things that I did not complete:

  1. Testing. Looks like it's working after building, but we need more complex tests
  2. For 0.16.0 version I returned CBitcoinAddressVisitor to base58.cpp because it used in patches (https://github.com/APshenkin/litecoin/blob/0.16.0-litecore/src/base58.cpp#L338). Maybe there is an option to overwrite patches to not do this. Also in would be great to add bech32 format address view support.