search

liteflow-labs / rarible-protocol-contracts

Interfaces for smart contracts used by Rarible
MIT License
0 stars 0 forks source link

Fixed origin fees #11

Closed NicolasMahe closed 1 year ago

NicolasMahe commented 1 year ago

Implement of fixed origin fees: https://github.com/liteflow-labs/rarible-protocol-contracts/pull/11/commits/edebb463261e20207babb40069f925248ec171d2

This was not complicated in term of logic but there is a possible issue: as the fees are in percent anymore, on partial fill on any amount, the origin fees are 100% applied.

NicolasMahe commented 1 year ago

closing this PR as we are not pursuing this direction