search

liteflow-labs / rarible-protocol-contracts

Interfaces for smart contracts used by Rarible
MIT License
0 stars 0 forks source link

Allow to restrict minters #4

Closed Hadrienlc closed 3 years ago

Hadrienlc commented 3 years ago

See #2

Hadrienlc commented 3 years ago
  • Is it possible to initialize the smart contract with the minterControlEnabled enabled and the owner/deployer as minter? Will it create a breaking changes (is it possible to have optional function parameter in solidity?)

By default now, there is not minting restriction when creating the contract so it have side effects i think. And no, it's not possible to have an optional parameter.

  • Could be nice to have a function to enable the minter control and put the owner has minter so in one transaction, the owner could turn on minter control with a basic config.

It's not really a standard way to do, since we manage a list of minters. I vote against this one but i will follow the majority

NicolasMahe commented 3 years ago

It's not really a standard way to do, since we manage a list of minters. I vote against this one but i will follow the majority

I'm good with 2 transactions then.

NicolasMahe commented 3 years ago

Closing this PR to create it on rarible repo https://github.com/rarible/protocol-contracts/pull/105