search

liteflow-labs / starter-kit

NFT Marketplace running on the Liteflow infrastructure
https://demo.liteflow.com
Apache License 2.0
11 stars 43 forks source link

Stay on the user results when searching #108

Closed antho1404 closed 1 year ago

antho1404 commented 1 year ago

Another question maybe more for @EmmanuelDrouin What do you think of adding a check when search if we are already on the user's page ? for example if I search a user, I might want to search a user again next. Right now when searching it will always go back to the NFT page, we could add a check to verify if we are on the users page or not and stay on the users page when we search again if we are.

Originally posted by @achampagnedev in https://github.com/liteflow-labs/starter-kit/issues/97#issuecomment-1363703327

EmmanuelDrouin commented 1 year ago

I agree with this proposal, the logic will apply in the same way for the "collection" part once implemented

EmmanuelDrouin commented 1 year ago

@achampagnedev @antho1404 is this issue still valid? From the production point of view this should have been added to the starter kit already (currently waiting a release)

achampagnedev commented 1 year ago

@achampagnedev @antho1404 is this issue still valid? From the production point of view this should have been added to the starter kit already (currently waiting a release)

This is included in the PR that should be merged soon, waiting for reviews #98

EmmanuelDrouin commented 1 year ago

Perfect @achampagnedev don't forget to link this issue to the PR so once merged it will close this issue ;)

EmmanuelDrouin commented 1 year ago

Closing this issue as #98 has been merged