Implement pagination on queries with hardcoded limit

liteflow-labs / starter-kit

NFT Marketplace running on the Liteflow infrastructure

https://demo.liteflow.com

Apache License 2.0

11 stars 43 forks source link

Implement pagination on queries with hardcoded limit #363

Open NicolasMahe opened 1 year ago

NicolasMahe commented 1 year ago

A few queries didn't have any limit implemented so I added an hardcoded limit of 100 to them in PR https://github.com/liteflow-labs/starter-kit/pull/362 to limit possible API related issues but without a pagination.

So we now need to implement a pagination system on those queries when needed. I added the comment # TODO: implement pagination to the codebase to find those queries easily.

NicolasMahe commented 9 months ago

@ismailToyran could you check what other queries have hardcoded pagination. If that's only the collection's traits values I think we can close this issue for now.