search

liteflow-labs / starter-kit

NFT Marketplace running on the Liteflow infrastructure
https://demo.liteflow.com
Apache License 2.0
11 stars 43 forks source link

fix walletLinkConnector url #49

Closed NicolasMahe closed 1 year ago

NicolasMahe commented 3 years ago

Example from the demo app: https://github.com/liteflow-labs/nft/blob/c450c80cec8b456bee0acd299d7cc1aa6d82d47e/apps/demo/pages/_app.tsx#L112-L116

the url should be set using a deployment variable from VERCEL and fallback to localhost for local dev.

antho1404 commented 3 years ago

I guess we could use the VERCEL_URL env variable for that https://vercel.com/docs/environment-variables#system-environment-variables

achampagnedev commented 2 years ago

This will be taken care of with the addition of a global config file :

https://github.com/liteflow-labs/nft/pull/1450

on hold for now.

EmmanuelDrouin commented 1 year ago

@antho1404 is this issue still relevant regarding the work we are doing on Wagmi?

antho1404 commented 1 year ago

Should be fix with the work on wagmi

EmmanuelDrouin commented 1 year ago

Keeping this open so we can double-check the result once the work on Wagmi is done

antho1404 commented 1 year ago

This issue was indeed fixed when migrating to wagmi