search

litegraph-tsx / litegraph.tsx

Modernization of litegraph and expansion of its capabilities
Other
8 stars 1 forks source link

Can't zoom in and out. #14

Open liusida opened 4 months ago

liusida commented 4 months ago

https://github.com/litegraph-tsx/litegraph.tsx/blob/a9e75ce1e6bf6795f11cb29a4587f65526670f44/src/core/LGraphCanvas.js#L2375-L2376

Should comment these lines out, as daniel did in his repo, otherwise we can't zoom in and out.

daniel-lewis-ab commented 4 months ago

I ended up commenting these ones out to match Comfy because I saw no change, and hes said not to. It affects drag and drop.

There's a handful of PRs around for similar issues and whenever you fix it for one person you seem to break it for another. But PR445 has been one im unsure about.

On Wed., Jul. 17, 2024, 07:16 Liu Sida, @.***> wrote:

https://github.com/litegraph-tsx/litegraph.tsx/blob/a9e75ce1e6bf6795f11cb29a4587f65526670f44/src/core/LGraphCanvas.js#L2375-L2376

Should comment these lines out, as daniel did in his repo, otherwise we can't zoom in and out.

— Reply to this email directly, view it on GitHub https://github.com/litegraph-tsx/litegraph.tsx/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC36LN67CTI33P2ATQYJKKLZMZVCBAVCNFSM6AAAAABLAT244KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTGNRQGEYDAMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

liusida commented 4 months ago

Interesting, the browser told me that e.deltaX is read-only, so it failed to execute the code following these lines.

daniel-lewis-ab commented 4 months ago

https://discord.gg/WF3NRuFf

Here, so we can chat better.

On Wed, Jul 17, 2024 at 8:17 AM Liu Sida @.***> wrote:

Interesting, the browser told me that e.deltaX is read-only, so it failed to execute the code following these lines.

— Reply to this email directly, view it on GitHub https://github.com/litegraph-tsx/litegraph.tsx/issues/14#issuecomment-2233440346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC36LNZ4JWTNQONWLO3EPPDZMZ4F7AVCNFSM6AAAAABLAT244KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGQ2DAMZUGY . You are receiving this because you commented.Message ID: @.***>

liusida commented 4 months ago

Sure, I'm in. But I am not good at Discording. xD Generally don't know where to look at.

atlasan commented 4 months ago

Probably a good approach is to build a object that mimic the original events, being that writable, and to pass that instead of the original. Probably would need to bind preventDefault and stopPropagation to originals to ensure everything works.