litentry / litentry-parachain

The Litentry parachain
https://docs.litentry.com
GNU General Public License v3.0
62 stars 20 forks source link

Review the JSONSchema in VC #1860

Open Kailai-Wang opened 1 year ago

Kailai-Wang commented 1 year ago

Context

At present the JSON schema in VC is pretty much a placeholder, it's neither used nor contains the real schema information. The schema registry is empty too.

There's some code prepared in the VCMP pallet. Meanwhile, we have some TODOs in the vc generation, e.g.: https://github.com/litentry/litentry-parachain/blob/6313204dfbbde0d6168dedca16952c7345352ddd/tee-worker/litentry/core/credentials/src/lib.rs#L336-L339

Tasks:

We can implement it along with the review if not too sophisticated, otherwise let's have dedicated issues for the implementation.


:heavy_check_mark: Please set appropriate labels and assignees if applicable.

Kailai-Wang commented 1 year ago

I have been reviewing and double-checking this recently, maybe I can provide some feedbacks/comments too

github-actions[bot] commented 1 year ago

:exclamation: This issue is stale because it has been open for 60 days with no activity. Please take proper action against it. @litentry/parachain