search

litentry / tee-worker

Based on the integritee-network/worker framework
Apache License 2.0
4 stars 2 forks source link

refactor stf task receiver #107

Closed BillyWooo closed 2 years ago

BillyWooo commented 2 years ago

resolves #106

BillyWooo commented 2 years ago

Can we delay this PR a bit? Based on the following reasons:

  • I'm currently working on web3-identity-verification which has a different structure
  • the web2/3 verification and ruleset-building will be moved out of receiver, because not all tasks need to go through the sender/receiver channel (before we add more generic callback trait), I think separate crates under core/ would be better
  • web3 verification doesn't need a httpclient
  • maybe MakeClient is not enough for ruleset building, imagine we have to build a ruleset where multiple http requests to different servers are needed.

My imaginary structure about stf-task + identity-verification + ruleset-build: they are all in parallel:

image

Ok. Let's wait a bit. The discussion with Zhiming, we thought all verifications can go through http. So we move it this way. But never mind, let's wait.

BillyWooo commented 2 years ago

obsolete, because of #89