litentry / tee-worker

Based on the integritee-network/worker framework
Apache License 2.0
4 stars 2 forks source link

rename request daemon and move around all litentry specific code together #99

Closed BillyWooo closed 2 years ago

BillyWooo commented 2 years ago

As discussed in #96 :

The naming is a bit inconsistent, this line is a good example 😂
we have a mix-up of extrinsic and XT. We should stick to one form.

But generally I'm not so convinced by the name extrinsic-request-daemon, as we are not passing extrinsic around, we just passing tasks/requests/closures around.

I'd suggest one of these names to replace extrinsic-request-daemon crate.

stf-task-handler
stf-request-handler
stf-closure-handler
It's prefixed with stf as it always comes from the handling of some stf TrustedCalls

And I prefer to put both the sender and receiver side of code into one crate for better readability, that is, move enclave-runtime/src/extrinsic_daemon.rs to the *-handler crate so that we have 3 files:

stf-task-proxy or stf-task-sender
stf-task-stub or stf-task-receiver
stf-task-daemon or stf-task-thread