literalice / terraform-aws-openshift

Creates OpenShift Container Platform(OCP) or OKD cluster
https://registry.terraform.io/modules/literalice/openshift/aws
35 stars 42 forks source link

Remove extraneous dollar sign in template #18

Open joshua-rutherford opened 5 years ago

joshua-rutherford commented 5 years ago

This is a minor fix to correct an extra dollar sign in the bastion init script template. Looks like a global replace on $ to $$ was performed when a global replace on ${ to $${ should have been performed. In short, the template engine does not replace $$? with anything and thus we are not actually checking the error status of the last command we are checking the PID of the bash command with a ? on the end.

$ echo $$?
86758?