search

literallymarvellous / dex-scaffold

MIT License
0 stars 0 forks source link

Remarks #1

Open PradhumnaPancholi opened 2 years ago

PradhumnaPancholi commented 2 years ago
  1. The file name needs to be updated to "DEX.sol".
  2. The function "ethToToken", "tokenToEth", "deposit", and "withdraw" do not return anything.
  3. Lack of comments.
literallymarvellous commented 2 years ago

I have changed the filename and added comments but I can't figure out why the functions don't return anything, they work as expected but don't return a value. The price function returns a value though.