search

literalpie / storybook-framework-qwik

Add Qwik support to storybook
28 stars 6 forks source link

qwikCityDecorator breaks static build #25

Open literalpie opened 1 year ago

DustinJSilk commented 1 year ago

I'll dig into this issue next week!

literalpie commented 1 year ago

That would be great! if you don't find an easy solution, I'd also be open to just removing the decorator. But then there's the question of whether a consumer will be able to use qwik-city features if they wrap components in the mock provider on their own. Does your use qwik+storybook use qwik-city? I wonder how common this use-case is.

Also, if it's difficult to make the vite configuration work both with and without qwik-city, we could probably have a storybook addon: storybook-framework-qwik/qwik-city so people can opt-in to the qwik-city stuff only if they need it. (and the addon could apply the decorator automatically)