search

literalpie / storybook-framework-qwik

Add Qwik support to storybook
28 stars 6 forks source link

ReferenceError: window is not defined in Qwik 1.4.2 #72

Open literalpie opened 7 months ago

literalpie commented 7 months ago

I see this warning in the console when using qwik 1.4.2, but not earlier versions. As far as I can tell, it doesn't actually break anything?

11:23:29 AM [vite] Error when evaluating SSR module /Users/benjaminkindle/Developer/temp/dec-qwik-sb/src/routes/layout.tsx:
|- ReferenceError: window is not defined
    at eval (/Users/benjaminkindle/Developer/temp/dec-qwik-sb/src/routes/layout.tsx:17:4)
    at async instantiateModule (file:///Users/benjaminkindle/Developer/temp/dec-qwik-sb/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:54696:9)
kumarasinghe commented 4 months ago

This is affecting me as well. Appreciate it if this could be fixed!

thasmo commented 4 months ago

Experiencing the same with qwik 1.5.4 and storybook 8.1.1.

literalpie commented 4 months ago

Is anyone seeing something broken because of this, or is it only the console error?

thasmo commented 4 months ago

Is anyone seeing something broken because of this, or is it only the console error?

Not sure, tbh. Started learning/testing Qwik and Storybook and it's just a bit distracting when trying to figure out things. :)