Do we actually need to check incoming tab-complete messages?

literalplus / commandblockerultimate

Blocks commands and does it well, or at least it thinks so. Compatible with BungeeCord and Spigot!

http://j.l1t.li/cmdblk

GNU General Public License v2.0

6 stars 5 forks source link

Do we actually need to check incoming tab-complete messages? #36

Closed literalplus closed 7 years ago

literalplus commented 7 years ago

https://github.com/xxyy/commandblockerultimate/blob/eea6d1fd9a5f62178e12f752d50702f4740994f7/spigot/src/main/java/io/github/xxyy/cmdblocker/spigot/listener/protocol/TabCompletePacketListener.java#L73

These should be handled by the outgoing check anyways, right?

literalplus commented 7 years ago

Yes, because the response packets don't contain the actual command that was completed, and we need to check for a blocked command being completed on the sub-command level.