search

liteserver / binn

Binary Serialization
Apache License 2.0
440 stars 58 forks source link

Improved make install target for custom prefix #28

Closed pbosetti closed 5 years ago

pbosetti commented 5 years ago

Allows install on custom prefix with make PREFIX=/opt/local install.

kroggen commented 5 years ago

Great contribution!

What do you think of making it lowercase?

I checked many places on internet and it appears to be the default. Example:

https://stackoverflow.com/questions/29366974/in-a-makefile-do-we-use-prefix-or-prefix

https://stackoverflow.com/questions/11307465/destdir-and-prefix-of-make

pbosetti commented 5 years ago

As you prefer. I am used to lowercase in autotools/configure, and uppercase for configurable options in pure make, though. BTW, I am afraid I forgot to explain its use in Readme...

pbosetti commented 5 years ago

By the way, binn is lovely. I am adding it here: xtemplate

kroggen commented 5 years ago

I am used to lowercase in autotools/configure, and uppercase for configurable options in pure make

Indeed, me too. But I guess we should use the default for this parameter.

Or to support both cases, if possible.

By the way, binn is lovely. I am adding it here: xtemplate

Nice!