search

liteserver / binn

Binary Serialization
Apache License 2.0
440 stars 58 forks source link

Makefile Improvements #36

Closed leojrfs closed 3 years ago

leojrfs commented 3 years ago

Hey! heres a couple of improvements for the Makefile:

Cheers

kroggen commented 3 years ago

OK, could you fix the conflicts? At least for me it appears a message informing about conflicts

leojrfs commented 3 years ago

OK, could you fix the conflicts? At least for me it appears a message informing about conflicts

Oh, I guess its because I renamed makefile to Makefile. Ill revert that

kroggen commented 3 years ago

You made the changes based upon a previous version, you can redo the PR with the changes on the last version/commit

kroggen commented 3 years ago

It is clear on the network graph

leojrfs commented 3 years ago

You made the changes based upon a previous version, you can redo the PR with the changes on the last version/commit

yeah, apparently based my branch on tag 3.0 instead of v3.0 which seems to be the most recent stable tag, can you confirm?

I will reapply the changes on master

kroggen commented 3 years ago

Thank you! =)