litespeedtech / lscache-drupal

LSCache Plugin for Drupal
GNU General Public License v3.0
14 stars 15 forks source link

You are referring to page cache and not dynamic page cache. #11

Open ndobromirov opened 5 years ago

ndobromirov commented 5 years ago

In Drupal there are two types of caches.

Page cache that works for anonymous users. Dynamic page cache - that caches parts of the page and generates only the non-cache-able parts from it.

From what I see in the code and descriptions in this module, you are making alternative variant for the page cache, but stating dynamic page cache everywhere.

You need to extend also documentation on what users installing this module should do with the core's dynamic page and standard page cache modules. Having both running at the same time is likely not needed.

Proper benchmarks comparing D8 core with and without the plugin will be appreciated.