search

litespeedtech / lscache_wp

LiteSpeed Cache for WordPress
http://wordpress.org/plugins/litespeed-cache/
GNU General Public License v3.0
210 stars 110 forks source link

Update instant_click.min.js #711

Closed Tymotey closed 2 months ago

Tymotey commented 2 months ago

Ticket: #802070 - LSCWP: Cookiebanners not working after upgrade Problem: Cookie banners(with plugin "Cookie Information - Consent Solution") were not loading

Solution: instant click library(minified version) have the same variables with "Cookie Information - Consent Solution". I minified the library with different variable names.

hi-hai commented 2 months ago

This PR can't be reviewed. Plz update the original JS.

szepeviktor commented 2 months ago

the original JS.

https://github.com/litespeedtech/lscache_wp/blob/v6.4/assets/js/instant_click.ori.js

Changes since v5.2.0 https://github.com/instantpage/instant.page/compare/v5.2.0...master

timotei-litespeed commented 2 months ago

There are no changes into the library. I just used instant_click from our plugin to rerun the minification. Everything is the same except variable names

hi-hai commented 2 months ago

Need to add a note for this change as hard to review diff: Used https://www.toptal.com/developers/javascript-minifier to optimize original JS lib.