CI changes

[timotei-litespeed]

Added PHP Code sniffer integration

For local:

• in Visual code install plugin: PHP Sniffer
• Plugin settings:
  • Auto detect set to Checked
  • Optional: can be set to run on save

Prerequirement: Node 16, Composer, PHP 7.2 Install: make sure there is a empty folder: .cache in root of plugin folder open terminal run: npm install run: composer install to run sniffer manually: composer run sniff-check

[szepeviktor]

I think this is not the GHA setup you want. May I contribute an improved strategy after this one gets merged?

[timotei-litespeed]

Contribute now, before merge

[szepeviktor]

Contribute now, before merge

I have to inform you that I am struggling with

• lack of EditorConfig (for Prettier)
• lack of syntax error check
• lack of coding standard
• lack of static analysis
• all right, we don't have unit/E2E tests

[timotei-litespeed]

@szepeviktor Ok, No problem. Do you have any suggested changes to Github CI actions?

For us current script is almost enought, we added Code Sniffer as a code check, no to correct or fix the code.

[szepeviktor]

Do you have any suggested changes to Github CI actions?

Yes. All the above tools. e.g. #696

[timotei-litespeed]

Moved to https://github.com/litespeedtech/lscache_wp/pull/744

@szepeviktor thank you for the code and iddeeas We are not really using WP code style and we are not adding Code Beautify(at least for now there are no plans)

[szepeviktor]

@timotei-litespeed Without the above tools, or without a coding standard you are theoretically cut off from bug-free code. That is very sad to see.

We are not really using WP code style

You could have a custom coding standard!!

[timotei-litespeed]

I agree that withput a coding standard there is posibility for bugs to appear. For now this automation will help us make the code cleaner.

Thank you for suggestions but for NOW the changes are enought for the time allocated for this change.

👍