fix: Improve parsing of ALLOWED_CORS_ORIGINS

litestar-org / litestar-fullstack

Litestar Fullstack Reference Application with React, Vite, SQLAlchemy, Docker, Task Queues, and more!

https://fullstack.litestar.dev/

MIT License

336 stars 56 forks source link

fix: Improve parsing of ALLOWED_CORS_ORIGINS #151

Closed TheGreatAlgo closed 7 months ago

TheGreatAlgo commented 7 months ago

Pull Request Checklist

[x] Pre-Commit Checks were ran and passed
[x] Tests were ran and passed

Description

The self.ALLOWED_CORS_ORIGINS = list(self.ALLOWED_CORS_ORIGINS) was incorrectly parsing the default string of '["*"]' to ['[', '"', '*', '"', ']'].

peterschutt commented 7 months ago

Thanks @TheGreatAlgo - its a good idea to mark the PR as draft until you are ready for a review :+1:

cofin commented 7 months ago

Sorry, accidentally removed the draft status on this.

@TheGreatAlgo thanks for the update on this one.

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud