search

litestar-org / litestar

Production-ready, Light, Flexible and Extensible ASGI API framework | Effortlessly Build Performant APIs
https://litestar.dev/
MIT License
5.66k stars 384 forks source link

Enhancement: Make `starlite run` work with servers besides uvicorn #1017

Closed provinzkraut closed 1 year ago

provinzkraut commented 1 year ago

What's the feature you'd like to ask for. Currently using the starlite run command requires users to install uvicorn, which is impractical should they be using e.g. hypercorn or Daphne. I'd like for the CLI to be able to support those servers as well.

kareemmahlees commented 1 year ago

@provinzkraut could you assign this to me

provinzkraut commented 1 year ago

After some consideration, I decided it's best to close this and not support this feature. It would require additional abstractions and make adding more options to the server harder, since it would restrict us to a subset of options available across all servers. Additionally, the benefit is low, since this is not intended to be used in production anyway, so supporting multiple servers isn't really relevant.

@kareemmahlees Thanks for the effort you already put into this, and I'm sorry that they've been a bit wasted now.