litestar-org / polyfactory

Simple and powerful factories for mock data generation
https://polyfactory.litestar.dev/
MIT License
1k stars 78 forks source link

feat: add recursion guard #468

Closed adhtruong closed 8 months ago

adhtruong commented 8 months ago

Pull Request Checklist

Description

Close Issue(s)

guacs commented 8 months ago

Note this may arguably be backwards breaking but would expect recursion errors so fine to add as a default

I agree with you. I don't think adding the recursion guard is a breaking change. It doesn't change the behavior nor the returned type.

adhtruong commented 8 months ago

All comments addressed now:

  1. Implementation of coverage updated
  2. Type errors resolved
guacs commented 8 months ago

@adhtruong that's fantastic! I'll take a look at it today or tomorrow :)

github-actions[bot] commented 8 months ago

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/468