fix: add min version to typing-extensions

litestar-org / polyfactory

Simple and powerful factories for mock data generation

https://polyfactory.litestar.dev/

MIT License

1k stars 78 forks source link

fix: add min version to typing-extensions #471

Closed hsorsky closed 8 months ago

hsorsky commented 8 months ago

Pull Request Checklist

[ ] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
[ ] Pre-Commit Checks were ran and passed
[ ] Tests were ran and passed

Description

Add minimum typing-extensions version in dependencies.

Close Issue(s)

Closes #470

guacs commented 8 months ago

@hsorsky thanks for pointing this out! Could you run pdm lock so that the lockfile gets updated as well? Also, please be sure to use the same pdm version as specified in .pre-commit-config.yaml or else the hook to check the lockfile will fail since pdm will return a non-zero exit code when it detects that the lockfile was created with a different pdm version.

Or if you want, I could do this for you. Just let me know!

hsorsky commented 8 months ago

@guacs if you could, that'd be great. I'm not a pdm user, so avoiding having to install it would be ideal

guacs commented 8 months ago

@all-contributors add @hsorsky for infra

allcontributors[bot] commented 8 months ago

@guacs

I've put up a pull request to add @hsorsky! :tada:

github-actions[bot] commented 8 months ago

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/471