Closed Vegemash closed 1 month ago
@adhtruong
Commit history and state seems to be out of sync with main. Can you sync up with main please?
rebased
Any chance we can get this in soon @guacs?
Any chance we can get this in soon @guacs?
Yupp, I'll be merging this and making a new patch release if the tests all pass.
Hm...the failing test doesn't seem to be related to the changes made here. In fact, it looks like a possible bug in pydantic.
Okay, so this is known bug in pydantic. However, it was fixed and a patch version was released, but we seem to be specifically installing v1.10.10 of pydantic as introduced in #389. Was there any specific reason for this, @adhtruong? Or can we specify only the minor version so that we always install the latest version in CI?
Hi @guacs, looking at that PR I think I copied what's there. Specifying patch versions keep things deterministic but should be safe to specify minor version only to unblock more easily.
SQLA versioning strategy should be aligned but happy for that to be a separate PR.
Thanks for the work on this @Vegemash !
@guacs @adhtruong #561 pydantic bump PR
@all-contributors add @Vegemash for code
@guacs
I've put up a pull request to add @Vegemash! :tada:
Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/527
Checklist
Description
Close Issue(s)
526