litestar-org / polyfactory

Simple and powerful factories for mock data generation
https://polyfactory.litestar.dev/
MIT License
988 stars 78 forks source link

fix: Send correct field_meta to avoid over nesting #527

Closed Vegemash closed 1 month ago

Vegemash commented 4 months ago

Checklist

Description

Close Issue(s)

Vegemash commented 2 months ago

@adhtruong

Commit history and state seems to be out of sync with main. Can you sync up with main please?

rebased

sam-or commented 1 month ago

Any chance we can get this in soon @guacs?

guacs commented 1 month ago

Any chance we can get this in soon @guacs?

Yupp, I'll be merging this and making a new patch release if the tests all pass.

guacs commented 1 month ago

Hm...the failing test doesn't seem to be related to the changes made here. In fact, it looks like a possible bug in pydantic.

guacs commented 1 month ago

Okay, so this is known bug in pydantic. However, it was fixed and a patch version was released, but we seem to be specifically installing v1.10.10 of pydantic as introduced in #389. Was there any specific reason for this, @adhtruong? Or can we specify only the minor version so that we always install the latest version in CI?

adhtruong commented 1 month ago

Hi @guacs, looking at that PR I think I copied what's there. Specifying patch versions keep things deterministic but should be safe to specify minor version only to unblock more easily.

SQLA versioning strategy should be aligned but happy for that to be a separate PR.

Thanks for the work on this @Vegemash !

Vegemash commented 1 month ago

@guacs @adhtruong #561 pydantic bump PR

guacs commented 1 month ago

@all-contributors add @Vegemash for code

allcontributors[bot] commented 1 month ago

@guacs

I've put up a pull request to add @Vegemash! :tada:

github-actions[bot] commented 1 month ago

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/527