litex-hub / litex-conda-packages

Conda build recipes for the toolchains needed by LiteX / MiSoC firmware
https://anaconda.org/LiteX-Hub
Apache License 2.0
2 stars 26 forks source link

yosys 0.9 #100

Closed ewenmcneill closed 4 years ago

ewenmcneill commented 4 years ago

I noticed, while trying to follow https://mithro-fomu-workshop.readthedocs.io/en/master/verilog.html using the yosys from https://anaconda.org/TimVideos/yosys/files, which as best I can tell is now being built from here, that the Conda build is currently of Yosys 0.8, but there's been a Yosys 0.9 release for a few months now which doesn't seem to have been built for Conda:

https://github.com/YosysHQ/yosys/releases/tag/yosys-0.9

In particular I noticed because the Fomu Workshop Makefile relies on:

Renamed "yosys -D" to "yosys -U", added "yosys -D" to set Verilog defines

which works on Yosys 0.9, but didn't work on Yosys 0.8 : -D PVT=1 silently doesn't do anything useful, causing the tests in blink.v to fail because there are no values defined; it can be made to work by adding:

`define PVT 1

or similar near the top of blink.v, but that is not as convenient for users.

(I wrote the Verilog for those tests in blink.v, and the Makefile, but at the time I didn't realise that -D FOO=bar was a bleeding edge yosys feature....)

Can we update the Conda yosys to 0.9? I'm not clear where in, eg, https://github.com/litex-hub/litex-conda-packages/tree/master/eda/syn/yosys (or elsewhere?) that the version to build is specified.

Ewen

mithro commented 4 years ago

This has been done!