litex-hub / zephyr-on-litex-vexriscv

BSD 2-Clause "Simplified" License
12 stars 10 forks source link

third_party/litex_boards is pinned at a too-old version #1

Closed tcal-x closed 3 years ago

tcal-x commented 4 years ago

I get an error because platforms/arty.py doesn't have _i2s_pmod_io at this older commit, 1356ebb4.

If I check out current master for third_party/litex_boards, this issue is resolved (but then I encounter another issue).

tcal-x commented 4 years ago

The new issue that I saw was due to request_all, used by current master targets/arty.py. Its definition was recently added to litex/litex/build/generic_platform.py, so it's not in the version pinned here. I think I can work around the issue by checking out litex-boards before the commit that uses request_all.

Ok, it seems to work if I use commit 8583c440 for litex-boards, and leave all of the other third party repos pinned where they are.

tcal-x commented 4 years ago

FYI @pawelsag @mateusz-holenko

mateusz-holenko commented 4 years ago

@tcal-x are you sure you are using the current versin of the repo? After 87965b053fca3b0b95a300cf43122bbd8f194b13 litex_boards should be ok - we couldn't reproduce the problem.

tcal-x commented 4 years ago

Thanks @mateusz-holenko , I hope to give it another try before our Wednesday meeting.

tcal-x commented 3 years ago

Yes it does work for me now, thanks all.