search

lithammer / nSpellTracker

Simple buff, debuff and cooldown tracking based on rFilter3 by Zork
1 stars 2 forks source link

Update for Shadowlands #5

Closed Xruptor closed 1 year ago

Xruptor commented 3 years ago

I added a few missing modules and some code fixes all over the place. Cleaned up the README and removed from leftover rFilter3 code that wasn't being used. Added some new examples to the Shaman module of the changes. Quite a bit of cleanup everywhere really lol.

lithammer commented 3 years ago

Quite a bit of cleanup everywhere really lol.

No kidding 😮 It's gonna take a bit of time to review. Why is LibCustomGlow necessary? I actually have an updated version locally, just haven't bothered pushing the changes 🤷‍♂️

Xruptor commented 3 years ago

Quite a bit of cleanup everywhere really lol.

No kidding 😮 It's gonna take a bit of time to review. Why is LibCustomGlow necessary? I actually have an updated version locally, just haven't bothered pushing the changes 🤷‍♂️

LibGlow adds the ability to have additional custom action glow animations. It's also used by WeakAuras. It's a neat little library.

Xruptor commented 3 years ago

Quite a bit of cleanup everywhere really lol.

No kidding 😮 It's gonna take a bit of time to review. Why is LibCustomGlow necessary? I actually have an updated version locally, just haven't bothered pushing the changes 🤷‍♂️

Oh in that case, if you would like to use your updated version, I'll retract this pull request before making anymore changes. 😄

lithammer commented 3 years ago

Quite a bit of cleanup everywhere really lol.

No kidding 😮 It's gonna take a bit of time to review. Why is LibCustomGlow necessary? I actually have an updated version locally, just haven't bothered pushing the changes 🤷‍♂️

Oh in that case, if you would like to use your updated version, I'll retract this pull request before making anymore changes. 😄

My changes are only bare minimum (fixing errors) and updated auras for some classes. So I'll definitely take this for a spin when I have some time, since it's seems like you've made some nice improvements 🙂 I'm actually surprised anyone was using this (except me of course).

Xruptor commented 3 years ago

I searched the internet for an addon that was a bare minimum of WeakAuras. I find the code and options of WeakAuras to be extremely bloated and really only wanted something really simple to track stuff. I was surprised to find that there are virtually almost no addons out there that do this except yours. Which I came across. So I decided to update the addon and provide the missing functionality that I needed. It worked out great. 😄

Xruptor commented 3 years ago

There seems to be a slight bug with the Spells module while tracking if is Usable and on Cooldown. I believe the global cooldown is causing issues. I will test it a bit more tomorrow. I think a combination of IsUsableSpell and GetSpellCooldown is required to circumvent this. I'll do some trial and error testing later lol.

Xruptor commented 3 years ago

Yep it's what I thought. It was a pesky global cooldown issue.

lithammer commented 3 years ago

Sorry for being slow. Noticed my subscription had ended (haven't logged in for many weeks). Gonna get that sorted.