search

litherum / cereal-conduit

Other
4 stars 6 forks source link

Properly terminate Partials in sinkGet when the upstream terminates #10

Closed NathanHowell closed 11 years ago

NathanHowell commented 11 years ago

Get parsers that rely on Get.isolate or Applicative.many to terminate fail to parse in sinkGet with this error message:

Data/Conduit/Cereal.hs:48:36-56: Irrefutable pattern failed for pattern Data.Serialize.Get.Fail msg

The fix is rather simple.

litherum commented 11 years ago

Looks good. Thanks for this! I'll upload a point release today.

litherum commented 11 years ago

Alright. Sorry for the delay, but I uploaded a point release today.

NathanHowell commented 11 years ago

No problem. We're still on 0.5.x but thought I'd at least get it fixed for everyone else :+1:

litherum commented 11 years ago

Do you mean cereal-conduit-0.5? Or another package?

NathanHowell commented 11 years ago

conduit-0.5.x.

On Mon, Sep 9, 2013 at 5:28 PM, litherum notifications@github.com wrote:

Do you mean cereal-conduit-0.5? Or another package?

— Reply to this email directly or view it on GitHubhttps://github.com/litherum/cereal-conduit/pull/10#issuecomment-24125712 .