search

litherum / cereal-conduit

Other
4 stars 6 forks source link

please update for conduit 0.5 #7

Closed clinty closed 11 years ago

clinty commented 12 years ago

The NeedInput/HaveInput/Done constructors have disappeared.

litherum commented 12 years ago

Ah, I didn't realize this. I'll update this over the next couple days. Thanks for letting me know.

litherum commented 12 years ago

Alright, the code should be updated. Do you want to give the new code a try to see if it suits your purposes? I'm hoping for some feedback before I push to hackage.

Thanks, Myles

clinty commented 11 years ago

Data/Conduit/Cereal.hs:35:15: Illegal polymorphic or qualified type: C.GLConduit BS.ByteString m o Perhaps you intended to use -XRankNTypes or -XRank2Types In the type signature for `conduitGet': conduitGet :: C.MonadThrow m => Get o -> C.GLConduit BS.ByteString m o

Data/Conduit/Cereal.hs:43:12: Illegal polymorphic or qualified type: C.GLSink BS.ByteString m r Perhaps you intended to use -XRankNTypes or -XRank2Types In the type signature for `sinkGet': sinkGet :: C.MonadThrow m => Get r -> C.GLSink BS.ByteString m r

Data/Conduit/Cereal.hs:52:14: Illegal polymorphic or qualified type: C.GSource m BS.ByteString Perhaps you intended to use -XRankNTypes or -XRank2Types In the type signature for `sourcePut': sourcePut :: Monad m => Put -> C.GSource m BS.ByteString

Data/Conduit/Cereal.hs:56:15: Illegal polymorphic or qualified type: C.GInfConduit a m BS.ByteString Perhaps you intended to use -XRankNTypes or -XRank2Types In the type signature for `conduitPut': conduitPut :: Monad m => Putter a -> C.GInfConduit a m BS.ByteString

clinty commented 11 years ago

That's with GHC 7.6.1.

litherum commented 11 years ago

I don't have that version of the compiler. If you add the -XRankNTypes and -XRank2Types arguments to the ghc line, does it compile? If so, I'll add a LANGUAGE directive to the file and release to hackage.

clinty commented 11 years ago

Data/Conduit/Cereal.hs and Test/Main.hs will both build with either -XRankNTypes or -XRank2Types.

litherum commented 11 years ago

Sounds good. Do you have any other issues before I push to hackage?

clinty commented 11 years ago

A quick test proves successful, so please push.

litherum commented 11 years ago

http://hackage.haskell.org/package/cereal-conduit-0.6