lithnet / access-manager

Access Manager provides web-based access to local admin (LAPS) passwords, BitLocker recovery keys, and just-in-time administrative access to Windows computers in a modern, secure, and user-friendly way.
Other
239 stars 20 forks source link

Small typo in PS1 script in WIKI #132

Closed PrzemyslawKlys closed 2 years ago

PrzemyslawKlys commented 2 years ago

In the script here: https://github.com/lithnet/access-manager/wiki/Creating-a-service-account-for-the-Access-Manager-Service has a typo

$amsServerName = "$(env.MachineName)" # Set this to the name of the server you are installing AMS on,

It should be "$env:COMPUTERNAME"

Also for lines, 26-34 will give a better answer what is wrong.

try 
{
    $ComputerExists = Get-ADComputer -Identity $amsServerName -ErrorAction Stop
} 
catch 
{
    Write-Warning "Computer account $amsServerName not found. Error: $($_.Exception.Message). Terminating."
    return
}
ryannewington commented 2 years ago

Fixed! Thankyou!