search

lithnet / access-manager

Access Manager provides web-based access to local admin (LAPS) passwords, BitLocker recovery keys, and just-in-time administrative access to Windows computers in a modern, secure, and user-friendly way.
Other
241 stars 20 forks source link

Underscore is not recognized as a supported character #140

Closed timatlee closed 2 years ago

timatlee commented 2 years ago

Describe the bug When entering a computer name that contains an underscore, an error message is generated stating "The computer name contains unsupported characters"

To Reproduce Steps to reproduce the behavior:

  1. Access the Lithnet AMS website
  2. Enter a computer name with an underscore: ct-tla_admin
  3. Provide a reason as required
  4. Informational message is shown under the computer name field.

Expected behavior Expected that I would be able to navigate to the next screen to select the information I want to retrieve.

LAPS UI considers this a valid computer name.

Screenshots If applicable, add screenshots to help explain your problem. image

image

Access Manager installation

Additional context

Logs There are no relevant data in any logs that I am able to find (when searching for ct-tla_admin.

ryannewington commented 2 years ago

@timatlee Thanks for pointing this one out. It's a tricky one as an underscore is illegal in a DNS host name, but legal in a netBIOS name. I've at least unblocked the input validator and allow this to be accepted, but I'm not sure if it will cause other issues in the application. Basic testing seems to work.

New build is here https://github.com/lithnet/access-manager/releases/tag/1.0.7941

timatlee commented 2 years ago

Hah, TIL that underscore is illegal. I don't think I've come across that before.

New build seems to be working as expected for us. Thanks for handling this so quick.