search

lithnet / googleapps-managementagent

Google Workspace Management Agent for MIM 2016
MIT License
12 stars 4 forks source link

The RateLimit configuration item does not seem to be used #35

Closed leoerlandsson closed 5 years ago

leoerlandsson commented 5 years ago

The RateLimit configuration item ("rate-limit") does not seem to be used in v2.0.6954 when creating the buckets. (E.g. DirectoryApiElement.RateLimit)

This leads to default rate limits being used, and not configurable.

Could you please check?

ryannewington commented 5 years ago

Do you know what the rate limit for classrooms actually is by default https://developers.google.com/classroom/limits

The default in the Lithnet.GoogleApp code was 48/10 seconds, but the default in the configSection for ClassroomApiElement.cs was 500.

I've set it to 50/second as per the above document, but not sure if that is correct

leoerlandsson commented 5 years ago

It should be 5/second (or 50/10 seconds).

I tried the higher number (5000 per 100 seconds or 50/sec) and got lots of 429 Backoff responses.

ryannewington commented 5 years ago

Fixed in 1.0.6996