lithnet / googleapps-managementagent

Google Workspace Management Agent for MIM 2016
MIT License
12 stars 4 forks source link

Error importing group with a slash in the email address #81

Closed kcrosby closed 1 month ago

kcrosby commented 4 months ago

We are running into an issue when importing groups that have a slash in the email address. It appears from the Event Log entry that it is interpreting the slash in the email address as a slash in the URL, and therefore the object is not found.

The (redacted) email address of the group is "something_a/b-test-reports@domain.com" and the URL it tries to get is:

/groups/v1/groups/something_a/b-test-reports@domain.com?alt=json

I think the email address needs to be URL encoded so that the URL is:

/groups/v1/groups/something_a%2Fb-test-reports%40domain.com?alt=json

We are running into with groups, but I would imagine it would be an issue with any object type.

ECMA2 MA import run caused an error. Error Name: <!DOCTYPE html>

Error 404 (Not Found)!!1

404. That’s an error.

The requested URL /groups/v1/groups/something_a/b-test-reports@domain.com?alt=json was not found on this server. That’s all we know. Error Detail: at Google.Apis.Services.BaseClientService.d__37.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult() at Google.Apis.Requests.ClientServiceRequest`1.d__31.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Google.Apis.Requests.ClientServiceRequest`1.d__27.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Google.Apis.Requests.ClientServiceRequest`1.d__26.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at Lithnet.GoogleApps.ApiExtensions.ExecuteWithRetry[T](ClientServiceRequest`1 request, Func`2 shouldRetry, Int32 retryAttempts, Int32 consumeTokens) at Lithnet.GoogleApps.ApiExtensions.ExecuteWithRetry[T](ClientServiceRequest`1 request, RetryEvents policy, Int32 retryAttempts, Int32 consumeTokens) at Lithnet.GoogleApps.ApiExtensions.ExecuteWithRetry[T](ClientServiceRequest`1 request, RetryEvents policy) at Lithnet.GoogleApps.GroupSettingsRequestFactory.Get(String mail) at Lithnet.GoogleApps.GroupRequestFactory.<>c__DisplayClass14_0.b__0(GoogleGroup group)

ryannewington commented 4 months ago

Hi @kcrosby

I created a group something_a/b-test-reports@domain.com in my domain and I'm not seeing this issue. I can get/update/delete it using the email address, and the slash is encoded correctly. What version of the MA are you running?

Ryan

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.