lithops-cloud / lithops

A multi-cloud framework for big data analytics and embarrassingly parallel jobs, that provides an universal API for building parallel applications in the cloud ☁️🚀
http://lithops.cloud
Apache License 2.0
315 stars 103 forks source link

Add an 'ibm' extra package #1337

Closed tomwhite closed 3 months ago

tomwhite commented 4 months ago

Part of #1324

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.
JosepSampe commented 4 months ago

Not sure if you want to tackle this here, but the kubernetes package is also required by IBM Code Engine, so it should be placed inside IBM extra. In consequence, you should also create lithops[kubernetes] and lithops[knative] containing the kubernetes package

tomwhite commented 4 months ago

Thanks for the guidance @JosepSampe. How does this look?

JosepSampe commented 4 months ago

Great! From my side I'm fine with the change, but as I stated in the issue, I wanted to get @gilv's approval, as IBM packages have been always in the default installation

JosepSampe commented 3 months ago

@gilv Any comment/objection on this? If no, I will proceed to merge it