Update 1289.json - Githubissues

tracedebrake commented 3 months ago

All modes supported, including vertical and horizontal swing (and even both at the same time)

litinoveweedle commented 3 months ago

Hello, thank you very much for the contribution. I have just few small requests:

Please create only one PR (one PR - it can contains multiple commits to multiple files)
Please keep "temperatureUnit": "C", int he file. Those are needed now for handling Fahrenheits as well (Celsius is default, but i added this to all codes as it would raise warning if missing.) I did not yet documented the data files format, so this you couldn't know this, I am going to provide documentation to files ASAP, probably when we will introduce presets.
Please give me some time, I would like to write down code quality test for data files, so during the PR merge it will be checked both by format, syntax and logic. I would like to you your PR (as it is first) to test this QC functionality, but I will need few days to write it.

Thank you.

litinoveweedle commented 2 months ago

Hello, I implemented detailed checks on the all device data files. Would you be please kind to pull updated master, merge it to your branch and re file the PR? Please also remove Readme update as from now docs are auto generated automatically from the code files. Thank you.

litinoveweedle / SmartIR

Update 1289.json #33