search

litinoveweedle / SmartIR

⏻ Control Home Assistant climate, media and fan devices via IR/RF controllers (Broadlink, Xiaomi, MQTT, LOOKin, ESPHome)
MIT License
45 stars 12 forks source link

Add MSZ-HR35VF #46

Open vxav opened 1 week ago

vxav commented 1 week ago

There is already MSZ-HR35VF under 1037 but we think there are different codes depending on the remote. I'm opening a PR here as the main project seems unmaintained.

I propose to add 1141 to the other remote.

Discussed 👇

vxav commented 5 days ago

Ping @litinoveweedle for visibility

litinoveweedle commented 5 days ago

Pong @vxav ;-)

I am very well aware of the few opened PR for new codes. The problem is, that I do not like the original way how the codes PRs are/were handled. So after fixing the integration code (hopefully now done) I need to address this topic as well.

I decided to create automation for checking submitted code files, both for syntax, logic and formatting. This script will be used in the PR workflow to test the CQ. I also need to produce script to automatically amend readme files to update supported devices list. I am not gonna spend my time evaluating each and every PR manually, as I simply don't have enough time. So please be patient I will try to do this ASAP.

vxav commented 4 days ago

No worries at all! I wasn't sure if you had notifications set on PRs but it looks like you are working on the right thing 🙂. In the meantime I have it in the custom_code folder (which was a great addition btw!).